-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for exporting to a Maven project #3003
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: Make sure to reformat and regenerate reference docs, so that the CI stops complaining about it.
Also, I know it's WIP, but I don't think the pom.xml
logic is used atm, you're still generating an SBT project when --maven
is passed.
modules/cli/src/main/scala/scala/cli/commands/export0/ExportOptions.scala
Outdated
Show resolved
Hide resolved
modules/integration/src/test/scala/scala/cli/integration/MavenTestHelper.scala
Outdated
Show resolved
Hide resolved
modules/cli/src/main/scala/scala/cli/commands/export0/Export.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some comments while going through the current progress.
modules/cli/src/main/scala/scala/cli/exportCmd/MavenProjectDescription.scala
Outdated
Show resolved
Hide resolved
modules/cli/src/main/scala/scala/cli/exportCmd/MavenProjectDescription.scala
Outdated
Show resolved
Hide resolved
modules/cli/src/main/scala/scala/cli/exportCmd/MavenProjectDescription.scala
Outdated
Show resolved
Hide resolved
modules/cli/src/main/scala/scala/cli/exportCmd/MavenProjectDescription.scala
Outdated
Show resolved
Hide resolved
modules/cli/src/main/scala/scala/cli/exportCmd/MavenProjectDescription.scala
Outdated
Show resolved
Hide resolved
modules/cli/src/main/scala/scala/cli/exportCmd/ProjectDescriptor.scala
Outdated
Show resolved
Hide resolved
modules/integration/src/test/scala/scala/cli/integration/MavenTestHelper.scala
Outdated
Show resolved
Hide resolved
modules/cli/src/main/scala/scala/cli/commands/export0/ExportOptions.scala
Show resolved
Hide resolved
modules/cli/src/main/scala/scala/cli/commands/export0/Export.scala
Outdated
Show resolved
Hide resolved
Co-authored-by: Piotr Chabelski <[email protected]>
… both test and main scope
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good already, we just need a couple tweaks. Great contribution!
modules/cli/src/main/scala/scala/cli/commands/export0/Export.scala
Outdated
Show resolved
Hide resolved
modules/cli/src/main/scala/scala/cli/exportCmd/MavenProject.scala
Outdated
Show resolved
Hide resolved
modules/cli/src/main/scala/scala/cli/exportCmd/MavenProject.scala
Outdated
Show resolved
Hide resolved
modules/cli/src/main/scala/scala/cli/exportCmd/MavenProject.scala
Outdated
Show resolved
Hide resolved
modules/cli/src/main/scala/scala/cli/exportCmd/MavenProjectDescriptor.scala
Show resolved
Hide resolved
modules/cli/src/main/scala/scala/cli/exportCmd/MavenProjectDescriptor.scala
Outdated
Show resolved
Hide resolved
modules/cli/src/main/scala/scala/cli/exportCmd/MavenProjectDescriptor.scala
Outdated
Show resolved
Hide resolved
modules/cli/src/main/scala/scala/cli/exportCmd/MavenProjectDescriptor.scala
Show resolved
Hide resolved
modules/integration/src/test/scala/scala/cli/integration/ExportMavenTestDefinitions.scala
Outdated
Show resolved
Hide resolved
modules/integration/src/test/scala/scala/cli/integration/ExportMavenTestJava.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bunch of things can still be done to polish the solution, but we can do those as a follow-ups.
LGTM, great contribution!
Extracted issues:
Export scala-cli project to Maven build with simple pom.xml.
Currently, implementation is done only for java projects