-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define dependency to scala files in using directives #1157
Conversation
59f2848
to
54782df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few questions I'm wondering about the new inputs:
- are they taken into account when watching files on disk? (IIRC, we only watch things from the initial
Inputs
instance) - do they work fine from BSP? (they should, but I'd add a test for that in
BspTestDefinitions
just in case) - are relative paths computed fine? like what if the
using file
directive is in a source in a sub-directory, like insrc/foo/bar/Something.scala
?
modules/directives/src/main/scala/scala/build/errors/WrongSourcePathError.scala
Outdated
Show resolved
Hide resolved
...ctives/src/main/scala/scala/build/preprocessing/directives/UsingSourceDirectiveHandler.scala
Outdated
Show resolved
Hide resolved
modules/options/src/main/scala/scala/build/options/ClassPathOptions.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it might be cool to highlight this feature in the scripts.md
guide as well, since that's where this feature would probably be at its most useful.
d8c44b6
to
6d48703
Compare
Now it should work, and upon every change, I re-compute actual
Yes, It works fine from BSP and I also added one
I think, it is out of the scope of this PR, it should be fixed in #1098. Now, it works the same as path resolving for the |
899a664
to
441f444
Compare
modules/directives/src/main/scala/scala/build/errors/WrongSourcePathError.scala
Outdated
Show resolved
Hide resolved
88f226e
to
72f0031
Compare
1cdffdc
to
6d700c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the minor commit (and maybe reworking the commits a bit so that we can do a merge commit), LGTM!
modules/build/src/test/scala/scala/build/tests/TestInputs.scala
Outdated
Show resolved
Hide resolved
1690c34
to
e36a4ac
Compare
e36a4ac
to
6c2e3bb
Compare
No description provided.