Fix running scala check in scala native #1190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armanbilge
reviewed
Jul 18, 2022
modules/integration/src/test/scala/scala/cli/integration/TestTestDefinitions.scala
Show resolved
Hide resolved
alexarchambault
approved these changes
Jul 27, 2022
There was a problem hiding this comment.
Let's merge, as this can help for #1158, but this is not really a fix, more a workaround. I think we should investigate why the added test framework isn't found by default (it should), and also have a look at the Scala Native junit compiler plugin, which apparently is necessary from sbt in order to run such tests (I tried manually adding it, but it seems it wasn't generating the expected junit-related classes).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.