Split integration tests #1202
Merged
Split integration tests #1202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwronski
reviewed
Jul 27, 2022
alexarchambault
force-pushed
the
split-integration-tests-ci
branch
16 times, most recently
from
861c100
to
10e15bd
Compare
|
Ideally, it'd be cool to generate that workflow definition from a more abstract definition… |
Running into weird external script not found issues on CI
There's still no UI to drop the existing caches, so it seems these grow and grow in size, reaching sizes like more than 6 GB sometimes, and taking quite some time to be downloaded upon start, and uploaded at the end of jobs (sometimes more than 5 minutes…). I'm not sure the cache brings much in that case…
alexarchambault
force-pushed
the
split-integration-tests-ci
branch
from
10e15bd
to
b875561
Compare
lwronski
approved these changes
Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These often take more than an hour to run on the CI… Let's see if splitting them helps here.
This will probably make the workflow definition more verbose. Indeed, keeping the OS-based build matrix and naively splitting the
native-testsjob intogenerate-launchers(to generate the native images), andnative-tests-1andnative-tests-2(running each half the ITs with the launchers generated by the previous job) might be a problem: for example, it makes the Windows image generation block starting the ITs on Linux and macOS, even if there launchers are done being generated. And if the Windows launcher generation fails, no IT is run at all. That is, no ITs start running until launchers are successfully generated for all 3 OSes.That means, we should replace the matrix-based
native-testsby 12 non matrix-based jobs:generate-linux-launchergenerate-macos-launchergenerate-windows-launchernative-linux-tests-1native-linux-tests-2native-linux-tests-3native-macos-tests-1native-macos-tests-2native-macos-tests-3native-windows-tests-1native-windows-tests-2native-windows-tests-3And
jvm-testsby:jvm-tests-1jvm-tests-2jvm-tests-3And
native-static-testsandnative-mostly-static-testsby:generate-static-launchergenerate-mostly-static-launchernative-static-tests-1native-static-tests-2native-static-tests-3native-mostly-static-tests-1native-mostly-static-tests-2native-mostly-static-tests-3