Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect ARM64 macs when downloading coursier launcher #1282

Merged
merged 1 commit into from
Aug 24, 2022

Conversation

keynmol
Copy link
Contributor

@keynmol keynmol commented Aug 24, 2022

This has knock off effects on the JDK that will be downloaded, and subsequently ability to build native image.

With this change I was able to built native image using ./.github/scripts/generate-native-image.sh and it seems to have the correct architecture.

Copy link
Contributor

@lwronski lwronski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @keynmol Thanks for contributing

@lwronski lwronski merged commit ae0d45b into VirtusLab:main Aug 24, 2022
@keynmol keynmol deleted the detect-aarch64 branch August 24, 2022 13:35
@Gedochao Gedochao added the enhancement New feature or request label Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants