-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make -d
and -classpath
options backwards compatible with the scala
command
#1340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gedochao
added
the
SIP-46
All the issues related to SIP-46 to turn Scala CLI into the official scala runner command.
label
Sep 9, 2022
Gedochao
force-pushed
the
backwards-compat-classpath
branch
2 times, most recently
from
September 13, 2022 06:50
a586ff7
to
73387c5
Compare
lwronski
reviewed
Sep 13, 2022
modules/cli/src/main/scala/scala/cli/commands/util/BuildCommandHelpers.scala
Outdated
Show resolved
Hide resolved
modules/cli/src/main/scala/scala/cli/commands/util/ScalacOptionsUtil.scala
Show resolved
Hide resolved
modules/cli/src/main/scala/scala/cli/commands/util/SharedOptionsUtil.scala
Outdated
Show resolved
Hide resolved
Gedochao
force-pushed
the
backwards-compat-classpath
branch
from
September 15, 2022 08:38
73387c5
to
a888a1f
Compare
lwronski
reviewed
Sep 15, 2022
modules/cli/src/main/scala/scala/cli/commands/util/ScalacOptionsUtil.scala
Outdated
Show resolved
Hide resolved
lwronski
approved these changes
Sep 15, 2022
…tput`; prevent the `-d` underlying compiler flag from being set repeatedly and default it to --compile-output
Gedochao
force-pushed
the
backwards-compat-classpath
branch
from
September 15, 2022 11:12
a888a1f
to
d1c0f28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
SIP-46
All the issues related to SIP-46 to turn Scala CLI into the official scala runner command.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #1310
Summary of changes (most of them, breaking changes):
compile
sub-command's--output
option has been renamed to--compilation-output
--compilation-output
option is now also available from therun
andpackage
sub-commands--output
option of thepackage
sub-command-d
option is no longer an alias for--dependency
, but for--compilation-output
scala
command's-d
-O -d -O path/to/compilation/output
now defaults to-d path/to/compilation/output
--classpath
option has been renamed to--print-classpath
, to better reflect what it actually doesscala-cli
's--classpath
andscala
command's-classpath
options (which have radically different meanings, BTW)--classpath
,--class-path
and-classpath
options are now aliases for the--extra jars
option-O -classpath -O path/to/classpath
now defaults to--extra-jars path/to/classpath
Reference docs have been generated for each of the commits, separately.