Add --debug option for integration tests #1378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wleczny
force-pushed
the
debug-option
branch
from
d9dd1ac
to
5c3a6fa
Compare
|
Unfortunately tests, which assert equality between expected output and output of tested command might fail, because Java remote debugging adds for example |
wleczny
force-pushed
the
debug-option
branch
from
5c3a6fa
to
8dba1da
Compare
modules/integration/src/test/scala/scala/cli/integration/TestUtil.scala
Outdated
Show resolved
Hide resolved
Gedochao
reviewed
Sep 21, 2022
Gedochao
reviewed
Sep 21, 2022
wleczny
force-pushed
the
debug-option
branch
3 times, most recently
from
aa1b379
to
e56aaeb
Compare
wleczny
force-pushed
the
debug-option
branch
from
e56aaeb
to
224b2ca
Compare
Gedochao
approved these changes
Sep 22, 2022
alexarchambault
approved these changes
Sep 22, 2022
wleczny
force-pushed
the
debug-option
branch
from
d652eb9
to
224b2ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
--debugoption for integration tests, which should improve DX for Scala CLI contributors.