Refactor ScalaCommand to enforce respecting help options
#1440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwronski
reviewed
Oct 12, 2022
modules/cli/src/main/scala/scala/cli/commands/ScalaCommand.scala
Outdated
Show resolved
Hide resolved
Gedochao
force-pushed
the
refactor-scala-command
branch
from
7aa56d4
to
fbd8e54
Compare
lwronski
approved these changes
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following sub-commands will now respect help options (
--help-native,--help-js,--scalac-help, other compiler options printing an ouptut regardless of inputs, etc):metabrowseexportfmtsetup-idedocThe idea is to prevent us from having to fix bugs like #1407 over and over again in the future.
It is now a lot easier to centralise certain pieces of logic in
ScalaCommand, if they apply for each and everysub-command.