Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support jvmRunEnvironment and jvmTestEnvironment for BSP #1519

Merged
merged 2 commits into from
Nov 4, 2022
Merged

Support jvmRunEnvironment and jvmTestEnvironment for BSP #1519

merged 2 commits into from
Nov 4, 2022

Conversation

Gedochao
Copy link
Contributor

@Gedochao Gedochao commented Nov 3, 2022

Fixes #1516

lwronski
lwronski reviewed Nov 3, 2022
View reviewed changes
Copy link
Contributor

@lwronski lwronski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to add a few entries to reflect-config.json, I'm afraid it won't work for the native launcher.

@Gedochao
Copy link
Contributor Author

Gedochao commented Nov 3, 2022

I think we need to add a few entries to reflect-config.json, I'm afraid it won't work for the native launcher.

should be fixed now, I think...

@Gedochao Gedochao marked this pull request as ready for review November 4, 2022 07:05
tgodzik
tgodzik approved these changes Nov 4, 2022
View reviewed changes
Copy link
Member

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from me! Thanks for looking into this!

@Gedochao Gedochao merged commit 8a0e528 into VirtusLab:main Nov 4, 2022
@Gedochao Gedochao deleted the bsp-jvm-run-environment branch November 4, 2022 08:28
@Gedochao Gedochao added the bug Something isn't working label Nov 4, 2022
@Gedochao Gedochao mentioned this pull request Mar 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodzik tgodzik tgodzik approved these changes

@lwronski lwronski lwronski approved these changes

@alexarchambault alexarchambault Awaiting requested review from alexarchambault

@wleczny wleczny Awaiting requested review from wleczny

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ScalaCLI doesn't support jvmRunEnvironment
3 participants
@Gedochao @tgodzik @lwronski