Make package --python work #1531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexarchambault
force-pushed
the
package-python
branch
4 times, most recently
from
fdad769
to
b94c50e
Compare
alexarchambault
force-pushed
the
package-python
branch
from
b94c50e
to
62d708b
Compare
alexarchambault
force-pushed
the
package-python
branch
from
62d708b
to
a138f18
Compare
lwronski
reviewed
Nov 21, 2022
modules/cli/src/main/scala/scala/cli/commands/package0/Package.scala
Outdated
Show resolved
Hide resolved
lwronski
reviewed
Nov 21, 2022
modules/cli/src/main/scala/scala/cli/commands/package0/Package.scala
Outdated
Show resolved
Hide resolved
lwronski
reviewed
Nov 21, 2022
modules/cli/src/main/scala/scala/cli/commands/package0/Package.scala
Outdated
Show resolved
Hide resolved
Rather than having each and every command handle them.
alexarchambault
force-pushed
the
package-python
branch
from
a138f18
to
9c98028
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit is a refactoring, useful now that most commands support
--python(after this PR, at least).Second commit adds a non regression test for
scala-cli compile --python(compileaccepting--pythonthanks to the first commit).Third commit adds support for
scala-cli package --python, using the same setup as coursier/coursier#2532.