Clean up references to scala-cli in SIP mode #1547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwronski
force-pushed
the
sip-help-message
branch
3 times, most recently
from
8c0324f
to
dc2685c
Compare
lwronski
force-pushed
the
sip-help-message
branch
from
dc2685c
to
29335fa
Compare
Gedochao
approved these changes
Nov 8, 2022
Gedochao
added
the
SIP-46
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I skipped runner name Scala CLI replacement for case-app options, e.g.DocOptions,SharedOptions. I don't have any idea, how to detect there if isSIPor not. Therefore I added there a more general nameRunner.Instead of adding support to use
ScalaCli.progNamein options, I replaced keywordscala-cliintoScala CLI.Fixes #1528