Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to customize Mill exported project name #1563

Merged
merged 2 commits into from
Nov 15, 2022

Conversation

carlosedp
Copy link
Contributor

This PR adds an option to export command allowing customization of Mill project name (currently assumed as "project").

This changes:

  • Mill project name on build.sc (object myprojectname extends ScalaModule {)
  • Mill project directory is named to the flag (./dest/myprojname/src/...)

@Gedochao
Copy link
Contributor

Hey, thanks for contributing!
Since you've added a new option, you need to also update the relevant reference doc to make the associated test pass on the CI.
You can do it automatically by running:

./mill -i generate-reference-doc.run

It seems there are conflicts with other recent changes as well, so make sure to rebase the branch while you're at it.

@Gedochao Gedochao added the enhancement New feature or request label Nov 10, 2022
@Gedochao
Copy link
Contributor

Can you also apply this new option in the integration test?
The current shape of our tests assume the Mill project name to always be project.

@carlosedp
Copy link
Contributor Author

Added docs and test case.

@Gedochao Gedochao merged commit af99fca into VirtusLab:main Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants