Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Scala 3-based case-app #1568

Merged
merged 3 commits into from
Nov 17, 2022

Conversation

alexarchambault
Copy link
Contributor

@alexarchambault alexarchambault commented Nov 10, 2022

This makes us use the Scala 3 artifacts of case-app (including the macros deriving CLI options parsers).

This is handled in 3 steps here:

  • first we use the Scala 3 artifacts from the cli module only (not from cli-options that derives parsers), and adjust some API calls - this breaks things at runtime (because of case-app Scala 2 and Scala 3 artifacts compatibility issues)
  • then we use them from cli-options too
  • lastly, we update to a version of scala-cli-signing relying on a Scala 3 case-app, so that there's no runtime issues with the scala-cli-signing stuff either.

The changes of the first two points mainly revolve around dropping the uses of Parser.Aux stuff (required to make the Scala 2 typer happy, and not necessary anymore in Scala 3).

@alexarchambault alexarchambault merged commit 1d80196 into VirtusLab:main Nov 17, 2022
@alexarchambault alexarchambault deleted the case-app-scala-3 branch November 17, 2022 08:52
@Gedochao Gedochao added the internal Internal or build-related changes label Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Internal or build-related changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants