Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a warning for the -run option of the legacy scala runner, instead of failing #1801

Merged
merged 2 commits into from
Jan 23, 2023
Merged

Add a warning for the -run option of the legacy scala runner, instead of failing #1801

merged 2 commits into from
Jan 23, 2023

Conversation

Gedochao
Copy link
Contributor

context: #1721

@Gedochao Gedochao added the SIP-46 All the issues related to SIP-46 to turn Scala CLI into the official scala runner command. label Jan 20, 2023
@Gedochao Gedochao mentioned this pull request Jan 23, 2023
Merged
lwronski
lwronski approved these changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@lwronski lwronski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gedochao Gedochao merged commit c13c105 into VirtusLab:main Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lwronski lwronski lwronski approved these changes

@MaciejG604 MaciejG604 Awaiting requested review from MaciejG604

Assignees
No one assigned
Labels
SIP-46 All the issues related to SIP-46 to turn Scala CLI into the official scala runner command.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gedochao @lwronski