Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Download inputs each time #214

Merged
merged 1 commit into from
Oct 15, 2021
Merged

Download inputs each time #214

merged 1 commit into from
Oct 15, 2021

Conversation

tpasternak
Copy link
Contributor

@tpasternak tpasternak commented Oct 13, 2021 •
edited
Loading

Not sure yet, but looks like this change causes:

  1. Inputs are downloaded each time
  2. If download fails, coursier gets input from cache

@tpasternak tpasternak force-pushed the download-inputs-each-time branch 3 times, most recently from 0266b2c to 46f6552 Compare October 14, 2021 09:04
@tpasternak tpasternak marked this pull request as ready for review October 15, 2021 12:50
alexarchambault
alexarchambault approved these changes Oct 15, 2021
View reviewed changes
Copy link
Contributor

@alexarchambault alexarchambault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be nice to have an option like --cache-downloads, that would just not call withTtl. But I guess that can be done in a later PR.

@tpasternak
Copy link
Contributor Author

Hey, I was going to do it, but I noticed it works in that way if there's no internet connection

@alexarchambault
Copy link
Contributor

alexarchambault commented Oct 15, 2021 •
edited
Loading

Merging, seems the CI error is transient (and a bit worrying), but unrelated to these changes.

@alexarchambault alexarchambault merged commit 52cb816 into VirtusLab:master Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexarchambault alexarchambault alexarchambault approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tpasternak @alexarchambault