Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix support of multiline shebang #2908

Merged
merged 1 commit into from
May 15, 2024
Merged

Fix support of multiline shebang #2908

merged 1 commit into from
May 15, 2024

Conversation

sierikov
Copy link
Contributor

@sierikov sierikov commented May 14, 2024 •
edited
Loading

I expanded a regular expression to support multiline shebang (#2901) and included the appropriate test case. Please see the short demo:

anim-opt

@Gedochao Gedochao linked an issue May 15, 2024 that may be closed by this pull request
script files (.sc) do not strip multiline shebang #2901
Closed
@Gedochao Gedochao self-requested a review May 15, 2024 09:16
@Gedochao Gedochao self-assigned this May 15, 2024
@Gedochao
Copy link
Contributor

To fix docs-tests failing on the CI (sclicheck.DocTests.cookbook introduction/instant-startup-scala-scripts) it should be enough to rebase this on top of the newest main.
It's a bug that got fixed in #2905

@sierikov sierikov force-pushed the fix/2901-multiline-shebang branch from cdf3cdb to 7707347 Compare May 15, 2024 09:26
Gedochao
Gedochao approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@Gedochao Gedochao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!
LGTM

@Gedochao Gedochao merged commit 31fbf2f into VirtusLab:main May 15, 2024
75 checks passed
@bishabosha
Copy link
Contributor

bishabosha commented May 15, 2024 •
edited
Loading

Actually it would be good to test this in script files (.sc) as reported in #2901 because the scala compiler itself strips multiline shebang from the top of a source, but script files avoid this because their content is copy pasted in the middle of the wrapper code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gedochao Gedochao Gedochao approved these changes

Assignees

@Gedochao Gedochao

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

script files (.sc) do not strip multiline shebang
3 participants
@sierikov @Gedochao @bishabosha