fix for 2954 running script in root dir #2988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gedochao
reviewed
Jun 28, 2024
Gedochao
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds fix for running script from the root directory.
Fixes #2954.
The problem occurs as a side-effect of calling
workspace.baseNamefrom within scala.build.input.Inputs.scalawhich throws an exception if
workspaceequalsos.root.See the calls to
.baseNamenear lines 155 and 469.The fix is to set
baseNameto an empty String ifworkspaceequalsos.root.A change was also made to scala.cli.ScalaCli.scala to insure that the logfile directory exists.