Ensure BSP respects --power mode #2997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gedochao
force-pushed
the
maintenance/bsp-power
branch
from
532ae6d
to
aa9150f
Compare
kasiaMarek
reviewed
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2678
This ensures the
bspsub-command (as called by an IDE) picks up on--powermode being set by:--powerlauncher option being passed tosetup-ide--powersub-command option being passed tosetup-ideSCALA_CLI_POWERenvironment variable being passed tosetup-idepowerkey of theconfigsub-commandIf any single one of these sets power mode on, BSP will pick it up.
Power mode should also be picked up by a running BSP server's
workspace/reloadwhensetup-ideorconfigare called.Note: once power mode gets picked up by BSP, we don't turn it off at any point, even when explicitly passed to
setup-ide. This is intentional behaviour, as we don't want to break anyone's existing IDE import to break. If you care for power mode to be turned off in your IDE, you need to explicitly restart the BSP server.