Fix default scaladoc config, so that id doesn't break all scaladoc links #3041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now running the doc command with default arguments in scala-cli always produced broken scaladoc links, because the default regex for external mappings mapped every tasty file that contained 'scala' to use the `scala-lang.org` mapping. And since scala-cli uses '.scala-build' directory for placing tasty files, almost all links were broken.
|
@KacperFKorban can you include an integration test for this? |
|
cc @Florian3k |
KacperFKorban
force-pushed
the
fix-default-scaladoc-config
branch
from
a1077dc
to
28a868f
Compare
|
Seems like it's failing on checks only. ./mill -i '{__[],_,integration._}.fix' |
KacperFKorban
force-pushed
the
fix-default-scaladoc-config
branch
from
28a868f
to
2ab2d29
Compare
…mbers to local links
KacperFKorban
force-pushed
the
fix-default-scaladoc-config
branch
from
2ab2d29
to
e1a982b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now running the doc command with default arguments in scala-cli always produced broken scaladoc links, because the default regex for external mappings mapped every tasty file that contained 'scala' to use the
scala-lang.orgmapping. And since scala-cli uses '.scala-build' directory for placing tasty files, almost all links were broken.