Make package command handle directories in extra classpath #3096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joan38
force-pushed
the
package-classpath
branch
2 times, most recently
from
7eaaa4f
to
a45ce34
Compare
|
@joan38 Hey, can you add an integration test for it? |
joan38
force-pushed
the
package-classpath
branch
4 times, most recently
from
c0487f4
to
43d5c7f
Compare
joan38
force-pushed
the
package-classpath
branch
from
43d5c7f
to
961f095
Compare
|
@Gedochao I was waiting for you to point where the tests are 😃 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3095