Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Scala CLI as scala related docs #3155

Merged
merged 9 commits into from
Sep 9, 2024

Conversation

Gedochao
Copy link
Contributor

@Gedochao Gedochao commented Sep 6, 2024

Closes #3147
Closes #3132

What this does:

  • the installation doc now includes a section about installing Scala CLI as the scala command via the Scala 3 command
  • the README mentions Scala CLI's status as the official language runner
  • filled in some missing scenarios in the old runner to Scala CLI as scala migration guide
  • the old runner to Scala CLI as scala migration guide now uses the correct commands for both runners in a Scala 3.5.0+ installation (scala & scala_legacy)
    • sclicheck has been modified to allow for those to be tested in the docs-tests workflow on the CI
    • the scala command in docs-tests is currently just an alias for scala-cli, rather than a 1:1 use of the scala wrapper from scala:3.5.0 installation
    • scalac and scala_legacy are currently launched through their main classes with scala-cli, rather than via an actual installation (although that's largely the same, just slower)
    • a potential follow-up could swap scala, scalac and scala_legacy to an actual coursier installation of the default Scala version, but that's out of scope for this PR
    • created a ticket: Add support for calling commands from an actual Scala language installation in sclicheck #3156
  • misc related docs improvements

image

@Gedochao
Copy link
Contributor Author

Gedochao commented Sep 6, 2024

cc @hamzaremmal

@Gedochao Gedochao changed the title Update Scala CLI as scala related docs Update Scala CLI as scala related docs Sep 6, 2024
@Gedochao Gedochao merged commit 7f5b16f into VirtusLab:stable Sep 9, 2024
20 checks passed
@Gedochao Gedochao deleted the docs/scala-cli-as-scala-revamp branch September 9, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants