Ensure --version passed to the default command works with --offline
#3207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://discord.com/channels/632150470000902164/901153021638082660/1288154845907517480
and also #3123 (comment)
TL;DR
--versionpassed together with--offlineto the default command still checked for the latest version of the CLI, as the--offlinethat was being parsed was tied to coursier, and notversion.What's funny, the 2 different
--offlineoptions have different spec levels, so this particular usage requires--powermode until a proper fix is in place.It's sort of a quick & dirty fix for now, need to unify
--offlineacross the different sub-commands as a follow-up (but that's a larger refactor).kudos to @kubukoz for spotting the problem.