Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to compile on x86 and arm #108

Closed
russellbanks opened this issue May 17, 2024 · 5 comments
Closed

Fails to compile on x86 and arm #108

russellbanks opened this issue May 17, 2024 · 5 comments

Comments

@russellbanks
Copy link

Compiling an application that uses this library fails on x86 and arm targets due to Wasmtime. I've tested this on i686-pc-windows-msvc, i686-unknown-linux-gnu, armv7-unknown-linux-gnueabihf, and i686-unknown-freebsd.

On x86 architectures, the build for wasmtime with no 'asm_sym' in the root or Wasmtime is being compiled for an architecture that it does not support.

On arm architectures, the build for cranelift-codegen fails with no supported isa found for arch 'armv7'.

@plusvic
Copy link
Member

plusvic commented May 17, 2024

Yep, that's a known issue. If wasmtime adds support for these platforms that would be great, if not, we must live without support for them. To be honest, I'm not very worried about not supporting those old platforms. Most users nowadays have 64-bits machines.

However, I would like to improve the experience for any developer that wants to depend on the yara-x crate, at least by breaking the compilation with a more explicative message in those unsupported platforms. Also, if you are only using this crate for the yara_x::mods::invoke feature, wasmtime is not really needed at all, and I think I may do something for supporting that feature in all platforms. Are you in this case? Or you plan to use the yara-x crate for scanning files with YARA rules?

@russellbanks
Copy link
Author

I personally just use yara_x::mods::invoke with the PE module to get resources, vs_version_info, etc, from PE files. I am considering looking into yara rules but currently, I just use the PE module.

@plusvic
Copy link
Member

plusvic commented May 17, 2024

Do you actually need support for x86 and armv7? Or just wanted to give a heads up?

@russellbanks
Copy link
Author

It's not imperative but I aim for my application to build and be built on as many platforms and architectures as I can so my users can run it on any device.

russellbanks added a commit to russellbanks/Komac that referenced this issue May 17, 2024
Could be re-added if VirusTotal/yara-x#108 is resolved
@plusvic
Copy link
Member

plusvic commented Sep 6, 2024

Closing because it's unfeasible to provide support for platforms that are not supported by wasmtime.

@plusvic plusvic closed this as completed Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants