Add deprecation warnings and raise exception for already deprecated ones #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eladkal
force-pushed
the
deprecate-automl
branch
from
ee79945
to
2aacd97
Compare
molcay
force-pushed
the
deprecate-automl
branch
7 times, most recently
from
8d86abd
to
338ca37
Compare
molcay
force-pushed
the
deprecate-automl
branch
3 times, most recently
from
9f17725
to
1554e19
Compare
molcay
force-pushed
the
deprecate-automl
branch
4 times, most recently
from
da243a1
to
c7748ae
Compare
molcay
force-pushed
the
deprecate-automl
branch
2 times, most recently
from
57b7fc4
to
fec27f3
Compare
…running or deferred state for BigQueryInsertJobOperator (apache#39442)
…running or deferred state for DataprocSubmitJobOperator (apache#39447)
* Disconnect GKE operators from deprecated hooks * Remove GKE unit tests from deprecation ignore list
closes apache#37156 The issues mentioned in the above meta-task are fixed
Signed-off-by: Maciej Obuchowski <[email protected]>
…pache#39480) * Add pre-commit to correct mismatching revision IDs in migration file Using `revision = ID` and `down_revision = ID` as the base, correct the `Revision ID: ID` and `Revises: ID` text in migration files. It's easy to forget to update these IDs when we change the down_revision or revision IDs. This will keep it in check. * fixup! Add pre-commit to correct mismatching revision IDs in migration file
Use `importlib.metadata.version` to get `airflow_version`. This is a more standardized approach to getting the version.
* add yq sample * fix style and links to doc from provider.yaml * fix style again * more links * reorg operators doc * fix links to how-to-guide
Update docker-compose command to docker compose as the previous version is outdated.
Previously, there was a lot of bad stuff happening around try_number. We incremented it when task started running. And because of that, we had this logic to return "_try_number + 1" when task not running. But this gave the "right" try number before it ran, and the wrong number after it ran. And, since it was naively incremented when task starts running -- i.e. without regard to why it is running -- we decremented it when deferring or exiting on a reschedule. What I do here is try to remove all of that stuff: no more private _try_number attr no more getter logic no more decrementing no more incrementing as part of task execution Now what we do is increment only when the task is set to scheduled and only when it's not coming out of deferral or "up_for_reschedule". So the try_number will be more stable. It will not change throughout the course of task execution. The only time it will be incremented is when there's legitimately a new try. One consequence of this is that try number will no longer be incremented if you run either airlfow tasks run or ti.run() in isolation. But because airflow assumes that all tasks runs are scheduled by the scheduler, I do not regard this to be a breaking change. If user code or provider code has implemented hacks to get the "right" try_number when looking at it at the wrong time (because previously it gave the wrong answer), unfortunately that code will just have to be patched. There are only two cases I know of in the providers codebase -- openlineage listener, and dbt openlineage. As a courtesy for backcompat we also add property _try_number which is just a proxy for try_number, so you'll still be able to access this attr. But, it will not behave the same as it did before. --------- Co-authored-by: Jed Cunningham <[email protected]>
…er (apache#38831) * update get_uri * update get_uri Signed-off-by: kalyanr <[email protected]> * update docstring Signed-off-by: kalyanr <[email protected]> * add and use sa_uri property * update database in sa_uri * update tests * remove client_encoding from test_get_uri * use sqlalchemy_url property * add default port * update tests * update usage of ports * revert client_encoding updates --------- Signed-off-by: kalyanr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for raising exception for the deprecated services of AutoML (Tables, Vision, Video Intelligence, Natural Language) which are EoL or will be EoL soon.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.