refactor(components): menu item migrate to fast #636
Conversation
yinonov
changed the title
|
|
||
| ```html preview center | ||
| `placement` property from _popup_ propagate through _menu_ and sets its position in accordance to its anchor. |
There was a problem hiding this comment.
I noticed that the position is according to the vwc-button, but it doesn't have the height of the button itself so the placement is strange:
this is right-start:
this is the same but with adding display:inline-block:
There was a problem hiding this comment.
I think the popup is OK, it sets the position relative to the anchor and the vwc-button as an anchor had a strange height cause its not "block" element.
There was a problem hiding this comment.
oh, should be fixed in button then. opened #695
| box-sizing: border-box; | ||
| align-items: center; | ||
| background-color: var(#{appearance.get-appearance-token(fill)}); | ||
| block-size: $min-block-size; |
There was a problem hiding this comment.
if there's break-word than we cant have a block-size. maybe min-block-size?
in vivid-2 we do not break lines, but have ellipses
| font: var(#{constants.$vvd-font-base}); | ||
| gap: $gap; | ||
| hyphens: auto; | ||
| inline-size: 100%; |
There was a problem hiding this comment.
this is great - but doesn't get the width that is set on menu....
The menu width + line break is not working well :(
| `anchor` property from _popup_ propagate through _menu_ and sets its anchor reference. | ||
|
|
||
| - Type: `string` | ||
| - Default: `''` | ||
|
|
||
| ```html preview center | ||
| <div style="position: relative"> |
There was a problem hiding this comment.
the preview is cut off - maybe add style for the html to set a preloaded height:
this PR introduces a new method circumventing the context lock-down to plain text by assigning textContent member to template instead of the convention of text property