Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Network Authentication & refactor AuthMethod #530

Merged
merged 14 commits into from
May 24, 2024
Merged

Conversation

SMadani
Copy link
Contributor

@SMadani SMadani commented May 21, 2024

This PR not only adds support for the "backend" Vonage Network Auth API, but also refactors the com.vonage.client.auth package. Most notably, it separates the TokenAuthMethod class into ApiKeyQueryParamsAuthMethod and ApiKeyHeaderAuthMethod to more clearly distinguish their roles. Consequently, the auth method usage in DynamicEndpoint implementations has been modified to accommodate this.

Furthermore, proper testing of the existing auth methods is now in place, along with a major refactoring of SignatureAuthMethod and the RequestSigning helper methods.

@SMadani SMadani marked this pull request as ready for review May 23, 2024 16:15
@SMadani SMadani merged commit 9042270 into main May 24, 2024
15 checks passed
@SMadani SMadani deleted the network-auth branch May 24, 2024 12:16
@SMadani SMadani mentioned this pull request May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant