Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revised toggleable light mode/dark mode #293

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

shiftingtech
Copy link
Contributor

Based on the work of GadgetAngel, but revised for mantainability.
Also draws on
https://derekkedziora.com/blog/dark-mode-revisited

This may still need some tweaking. Primarily, I'm not happy with the current location of the dark/light toggle

Based on the work of GadgetAngel, but revised for mantainability.
Also draws on
https://derekkedziora.com/blog/dark-mode-revisited
@nemgrea
Copy link
Contributor

nemgrea commented Dec 27, 2022

do you want to incorporate anything from this most recent issue into this?
#316

@shiftingtech
Copy link
Contributor Author

I'm not sure any addition is necessary. (though the suggestion of making the color names a bit clearer is a good one). I think the original concept from GadgetAngel's version was to have the light theme be the color blind friendly one, which makes as much sense to me as anything...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants