-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'vundlelog' filetype + settings/highlighting #633
Conversation
f294544
to
a6654c9
Compare
Friendly ping. :) When's a good time for me to follow up on this? |
a6654c9
to
e91f828
Compare
I had tweaked the syntax file, but forgotten to test whether So as far as I can see, this is ready for review. By the way, here's a tip I figured out to help test this change, even when all the plugins are up-to-date (so |
e91f828
to
e642d2a
Compare
This latest update fixes highlighting for the usernames. Here's an example input which didn't work with the old regex, but now does work:
Names such as I have kept my commits in a squashed state at every stage, as per the contributing guidelines. I believe this PR is ready for review. |
Friendly ping. I've been using this for weeks without issue now; I think it's ready for review. |
Friendly ping. After a further two weeks of usage, I still find no issues (and it greatly improves the experience of checking to see what's changed). I think this is ready for review. |
I can try to take a look but unfortunately I think most PRs are going to be blocked until #619 can be dealt 😟 |
Thanks for offering. Are the tests coming soon? I haven't seen anything substantial on that thread for a few months. Also, this PR is mostly orthogonal to testing; it only affects the update log. |
@chiphogg did quick test and it works well, except that PR needs to be rebased. |
e642d2a
to
0d330db
Compare
Thanks for reviewing! I've rebased now, and it should be good to go. |
@chiphogg thank you! |
@gmarik sounds fairly safe yes. If someone can review and merge that's cool else I can try to look at it this weekend 😄 |
@ryanoasis feel free to merge it once confirmed! Thanks! |
This weekend turned out to be pretty busy for me so I wasn't able to get around to this. If someone else can that is great else I will try sometime this week. Cheers! |
@ryanoasis @chiphogg ok, i'm gonna test it today… |
@gmarik 👍 thanks. Sorry I couldn't get around to it.. just had too many other things going on. I will try to contribute on testing perhaps another PR 😞 |
@ryanoasis hey, no problem! :) |
😅 |
Add 'vundlelog' filetype + settings/highlighting
@chiphogg thank you! |
Glad to help. Thanks for merging :) |
As requested in #623, I've added some basic syntax highlighting and settings to the syntax file. I hope this will make it a lot easier for people to see what has changed in their plugins since the previous update.