Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for AnnotationOfTypedLiteral #161

Merged
merged 1 commit into from
Jul 2, 2023
Merged

add support for AnnotationOfTypedLiteral #161

merged 1 commit into from
Jul 2, 2023

Conversation

heinpa
Copy link
Collaborator

@heinpa heinpa commented Jun 5, 2023

Required change to QanaryTriplestoreConnector.java to extend the Qanary Platypus Wrapper QB component

@heinpa heinpa requested a review from anbo-de June 5, 2023 16:18
@heinpa heinpa force-pushed the extend-triplestore-connector branch from c1a8965 to 478020c Compare June 5, 2023 17:13
@heinpa
Copy link
Collaborator Author

heinpa commented Jun 5, 2023

@anbo-de
Caching test RestTemplateCacheLiveTest.givenRestTemplate_whenRequested_thenLogAndModifyResponse seems to be unreliable. Sometimes it fails even if no changes were made to the code base:

RestTemplateCacheLiveTest.givenRestTemplate_whenRequested_thenLogAndModifyResponse:73->callRestTemplateWithCaching:107 expected: <0> but was: <1>

It also failed on the first automatic run after opening this PR, but after a manual re-run of the build process, all checks completed successfully.

@heinpa heinpa marked this pull request as ready for review June 13, 2023 14:06
@heinpa heinpa requested a review from Perevalov June 27, 2023 14:24
@anbo-de
Copy link
Member

anbo-de commented Jul 2, 2023

@anbo-de Caching test RestTemplateCacheLiveTest.givenRestTemplate_whenRequested_thenLogAndModifyResponse seems to be unreliable. Sometimes it fails even if no changes were made to the code base:

RestTemplateCacheLiveTest.givenRestTemplate_whenRequested_thenLogAndModifyResponse:73->callRestTemplateWithCaching:107 expected: <0> but was: <1>

It also failed on the first automatic run after opening this PR, but after a manual re-run of the build process, all checks completed successfully.

@heinpa Yes, it will be replaced soon.

@anbo-de anbo-de merged commit 8034720 into WDAqua:master Jul 2, 2023
@anbo-de anbo-de deleted the extend-triplestore-connector branch July 2, 2023 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anbo-de anbo-de anbo-de approved these changes

@Perevalov Perevalov Awaiting requested review from Perevalov

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heinpa @anbo-de