Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend method getTextualRepresentation in QanaryQuestion #176

Merged
merged 2 commits into from
Aug 10, 2023
Merged

Extend method getTextualRepresentation in QanaryQuestion #176

merged 2 commits into from
Aug 10, 2023

Conversation

heinpa
Copy link
Collaborator

@heinpa heinpa commented Jul 19, 2023

Add getTextualRepresentation() with additional String parameter language.

Extend select_uri_textual_representation to include URI of current question.

Refactor SPARQL queries to resource files.

@heinpa heinpa requested a review from anbo-de July 19, 2023 15:32
@heinpa heinpa force-pushed the get-language-textual-representation branch from 4286c7c to a911d7d Compare July 25, 2023 13:24
@anbo-de anbo-de self-assigned this Aug 10, 2023
anbo-de
anbo-de approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@anbo-de anbo-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@anbo-de anbo-de merged commit bfc5897 into WDAqua:master Aug 10, 2023
4 checks passed
@anbo-de anbo-de deleted the get-language-textual-representation branch August 10, 2023 22:47
@anbo-de
Copy link
Member

anbo-de commented Aug 10, 2023

@heinpa Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anbo-de anbo-de anbo-de approved these changes

Assignees

@anbo-de anbo-de

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heinpa @anbo-de