Cleanup and lint fix

WEEE-Open · May 5, 2024 · 96dd9ca · 96dd9ca
1 parent abeb38a
commit 96dd9ca
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 13 deletions.
diff --git a/public/sugo.php b/public/sugo.php
@@ -2,8 +2,6 @@
 
 namespace WEEEOpen\Crauto;
 
-use DateTimeZone;
-
 require '..' . DIRECTORY_SEPARATOR . 'vendor' . DIRECTORY_SEPARATOR . 'autoload.php';
 Authentication::requireLogin();
 
@@ -16,17 +14,8 @@
 	CRAUTO_LDAP_STARTTLS
 );
 
-$users = [];
 $selectedUser = null;
 if (Authentication::isAdmin()) {
-	$ldap = new Ldap(
-		CRAUTO_LDAP_URL,
-		CRAUTO_LDAP_BIND_DN,
-		CRAUTO_LDAP_PASSWORD,
-		CRAUTO_LDAP_USERS_DN,
-		CRAUTO_LDAP_GROUPS_DN,
-		CRAUTO_LDAP_STARTTLS
-	);
 	$users = $ldap->getUsers(['givenname', 'sn', 'signedsir', 'nsaccountlock', 'mail']);
 	if (isset($_GET['uid'])) {
 		$selectedUser = $_GET['uid'];

diff --git a/src/Authentication.php b/src/Authentication.php
@@ -78,7 +78,7 @@ public static function authenticate()
 
 		if (TEST_MODE) {
 			error_log('TEST_MODE, faking authentication');
-			switch(TEST_MODE_SSO) {
+			switch (TEST_MODE_SSO) {
 				case 1:
 				default:
 					$_SESSION['uid'] = 'test.administrator';

diff --git a/templates/index.php b/templates/index.php
@@ -14,7 +14,7 @@
 		Error: <?= $this->e($error) ?>
 	</div>
 <?php endif ?>
-<?php if (!$signedSir): ?>
+<?php if (!$signedSir) : ?>
 	<p class="alert alert-warning">You need to sign your SIR! <a href="/sugo.php?uid=<?= urlencode($uid)?>" class="btn btn-sm btn-warning">Sign the SIR</a></p>
 <?php endif ?>
 <h2>Enabled services</h2>

diff --git a/templates/sugo.php b/templates/sugo.php
@@ -1,4 +1,5 @@
 <?php
+
 /** @var string|null $selectedUser */
 /** @var array $users */
 $this->layout('base', ['title' => 'Welcome'])