Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump pyifcb to latest release (1.1.1) #403

Merged
merged 1 commit into from
Jul 29, 2024
Merged

bump pyifcb to latest release (1.1.1) #403

merged 1 commit into from
Jul 29, 2024

Conversation

joefutrelle
Copy link
Contributor

No description provided.

@joefutrelle joefutrelle added the dependencies Pull requests that update a dependency file label Jul 29, 2024
@joefutrelle joefutrelle added this to the v4.2 milestone Jul 29, 2024
@joefutrelle joefutrelle self-assigned this Jul 29, 2024
@joefutrelle
Copy link
Contributor Author

@mike-kaimika suggested review process is to build and run, sync some data into a fresh dataset, and make sure "volume analyzed" is between 0 and 5, and mosaics work.

Copy link
Collaborator

@mike-kaimika mike-kaimika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joefutrelle
This all looks good. As suggested, I pulled down this branch, rebuilt the docker container and sync'd a new dataset (well the same one, but I deleted all the bins first). The mosaics are rendering, and all bins on my example had ml Analyzed between 2 and 3, so that lines up with your comments

@joefutrelle joefutrelle merged commit 5edec2e into master Jul 29, 2024
@joefutrelle joefutrelle deleted the pyifcb_1.1.1 branch July 29, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants