Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update explainer.md #7

Merged
merged 3 commits into from
Jan 24, 2024
Merged

Update explainer.md #7

merged 3 commits into from
Jan 24, 2024

Conversation

b1tr0t
Copy link
Contributor

@b1tr0t b1tr0t commented Dec 19, 2023

  • Edited for flow/readability
  • Added a challenge we intend to address with PEPC (insufficiency of existing mitigations)
  • Added a rejected alternative, an allow list based approach

- Edited for flow/readability
- Added a challenge we intend to address with PEPC (insufficiency of existing mitigations) 
- Added a rejected alternative, an allow list based approach
explainer.md Outdated Show resolved Hide resolved
explainer.md Outdated Show resolved Hide resolved
of the user's interaction in the content area, and the user's intent.

![](images/image1.png) \
*Example 1. A notification permission prompt on a news site (contents
Copy link
Contributor

@marcoscaceres marcoscaceres Dec 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This example seems contrived... for Notifications, the API doesn't require a user gesture to request permission.

to confirm, try this in on any site via the developer console (i.e., without user activation)

Notification.requestPermission()

That's a flaw in the Notifications API (which we should fix collectively as user agents), but the notification prompt is not resulting from the user clicking - the site can show the permission prompt at any time.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a real-world scenario that I've personally experienced several times. The notifications API might not require a user gesture, but for some reason it seems that some sites will request the notification permission as soon as a click happens in the page.

@b1tr0t
Copy link
Contributor Author

b1tr0t commented Dec 20, 2023

As much of the team is now out on holidays, I'll get back on this in the new year. Thanks so much for the detailed analysis!
We'll address the clarity issues in the explainer and look forward to a deeper discussion of the central concerns in 2024.

Happy holidays and new year!

@andypaicu andypaicu self-assigned this Jan 24, 2024
andypaicu and others added 2 commits January 24, 2024 12:16
Co-authored-by: Marcos Cáceres <[email protected]>
Co-authored-by: Marcos Cáceres <[email protected]>
@andypaicu
Copy link
Collaborator

I have extracted the generic pieces of feedback into #8. For the rest of them, I have accepted the 2 edit suggestions and I will follow-up with another PR to cover the more involved suggestions (event names, and mentioning the time-to-interaction signal).

@andypaicu andypaicu merged commit d790832 into WICG:main Jan 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants