-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should getComputedAccessibleNode() take a node, instead of an element? #185
Comments
Assuming we do this, we need a special role string for text. @asurkov WDYT? |
Fix a crash by allowing computed accessible nodes to be backed by a Node*, rather than requiring an Element*. See AOM issue WICG/aom#185 Bug: 792783,1274837,1245437 Change-Id: Ib5f5ff558a1a848797adc79aac43deb31fd414dd
There's some baggage related to the "text" role, as previously implemented by WebKit, and then removed from the the spec drafts later. WebKit didn't remove support for the old role, but b/c of the baggage and webcompat issue, I'd prefer we avoid making an "text" role, regardless of whether it's abstract or concrete. cc @joanmarie I also recall there was consensus to not work on the computed tree for the time being. Has that changed? |
Fix a crash by allowing computed accessible nodes to be backed by a Node*, rather than requiring an Element*. See AOM issue WICG/aom#185 Bug: 792783,1274837,1245437 Change-Id: Ib5f5ff558a1a848797adc79aac43deb31fd414dd
I think either of ways is a livable thing:
|
We could also have it have an undefined role, e.g. ax_node.role === undefined.
Probably not. I'm just trying to fix a crash that occurs in our current implementation, which is behind a flag. The crash occurs because nextSibling matches text nodes. I'm not really too excited about this API unless there are consumers banging down our door for it. If we don't want to change the IDL, I'm happy to find another solution. |
Since one can only get a computed AX node for an element, it makes sense sense to skip over document and text nodes. However, an element is not required for all nodes. An example is a pseudo element styled as display:table, which has some AX nodes that do not have any kind of matching DOM node. Bug: WICG/aom#185 Change-Id: Icb1f19c3c8c524593cb31e19af3d4b44f6d565b4
I suggest that it should be possible to pass a node to getComputedAccessibleNode().
The text was updated successfully, but these errors were encountered: