Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URL matching should use URLPattern #48

Closed
domenic opened this issue Sep 5, 2023 · 1 comment · Fixed by #51
Closed

URL matching should use URLPattern #48

domenic opened this issue Sep 5, 2023 · 1 comment · Fixed by #51

Comments

@domenic
Copy link

domenic commented Sep 5, 2023

This is the new foundation we're using for URL matching across the web platform. https://github.com/WICG/urlpattern

Introducing a new type of pattern is counterproductive to our efforts. (I can't find the details from the explainer, but it says "This is parsed as a URL that relative or absolute URLs as well as * wildcard expansion.", and then #42 is open also I guess.)
This was referenced Sep 5, 2023
Closed
Closed
@annevk
Copy link

annevk commented Sep 11, 2023

This makes sense to me, modulo the concerns in WebKit/standards-positions#61 (comment).

pmeenan added a commit to pmeenan/compression-dictionary-transport that referenced this issue Sep 11, 2023
@pmeenan
Switched the match param to use a URLPattern
fe84ee2 
Fixes WICG#42, fixes WICG#48
@pmeenan pmeenan mentioned this issue Sep 11, 2023
Merged
@domenic domenic mentioned this issue Sep 12, 2023
Open
pmeenan added a commit that referenced this issue Sep 15, 2023
@pmeenan
Switched the match param to use a URLPattern (#51)
bbf1dd7 
Fixes #42, fixes #48
This was referenced Oct 4, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switched the match param to use a URLPattern pmeenan/compression-dictionary-transport
2 participants
@domenic @annevk