-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create explainer.md #16
Merged
Merged
Commits on Jul 15, 2016
-
Long overdue, this is an attempt to describe the API and its reasons for existing
Configuration menu - View commit details
-
Copy full SHA for 267789a - Browse repository at this point
Copy the full SHA 267789aView commit details -
Configuration menu - View commit details
-
Copy full SHA for c04da75 - Browse repository at this point
Copy the full SHA c04da75View commit details -
Configuration menu - View commit details
-
Copy full SHA for 68d83e7 - Browse repository at this point
Copy the full SHA 68d83e7View commit details
Commits on Jul 22, 2016
-
- cookieList is indeed an array. Examples have been expanded to show this - regexp is gone in favor of strict name matching, name prefix matching, and "give me everything" where the developer-supplied script sorts it out; tried to strike a balance between not waking up handlers when the change is to an unrelated cookie that happens to be in-scope and the matching is definitely practical to implement in the browser (exact match or exact prefix match - both are used in ServiceWorker already) on the one hand and allowing JS to decide whether a change is interesting on the other hand (omit interest list and you get called back every time) - switched to `get` - added `delete` - proposed restricting write operations to secure contexts - `expires` rather than `expiration`, added explicit examples of numeric expiration timestamps - added some initial discussion of security implications - overhauled change monitoring APIs - attempted to explain change coalescing - attempted to explain ServiceWorker API and rationale - `match`/`matchAll` are gone - `await` - silent failures are gone - changed event name
Configuration menu - View commit details
-
Copy full SHA for 2a84c02 - Browse repository at this point
Copy the full SHA 2a84c02View commit details -
- minor reformatting - note limitation of ServiceWorker cookie monitoring
Configuration menu - View commit details
-
Copy full SHA for dba7692 - Browse repository at this point
Copy the full SHA dba7692View commit details -
Configuration menu - View commit details
-
Copy full SHA for c94e291 - Browse repository at this point
Copy the full SHA c94e291View commit details -
clarify that the only ephemeral script contexts supported is ServiceWorker
Configuration menu - View commit details
-
Copy full SHA for 9ee4444 - Browse repository at this point
Copy the full SHA 9ee4444View commit details -
Configuration menu - View commit details
-
Copy full SHA for b8c6d90 - Browse repository at this point
Copy the full SHA b8c6d90View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2fb063c - Browse repository at this point
Copy the full SHA 2fb063cView commit details
Commits on Jul 27, 2016
-
Applying feedback, round N + modify CookieObserver
- Mention cookie-aversion and other contexts with disallowed cookie access, and our chosen approach: reject operations, allow monitoring (but don't call back unless/until reads are possible) - Explain why we path-scope a ServiceWorker/disallow reading for out-of-scope URLs - Describe how fragile path-scoping is for this API - Mention possibly-surprising port number handling - Mention possibly-surprising different-path cookie-writing - Removed unobserve, replaced it with less-flexible disconnect - Changed description of observe to clarify additive behavior and lack of duplicated change reports - Changed (optional) matchType to accept one of two values: 'equals' and 'startsWith'; clarified that 'equals' is the default - CookieStore and URL are now one-per-item in CookieChange entries - The first parameter for CookieObserver callbacks and event.data for the CookieChangeEvent are now simply arrays of cookie changes - The second paramter for CookieObserver callbacks is now the CookieObserver - The url is now per-CookieInterest item in calls to observe and InstallEvent's registerCookieChangeInterest
Configuration menu - View commit details
-
Copy full SHA for fe094d2 - Browse repository at this point
Copy the full SHA fe094d2View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.