Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to hide the "Back to Tab" button #114

Merged
merged 4 commits into from
Mar 13, 2024

Conversation

steimelchrome
Copy link
Collaborator

This adds a new allowReturnToTab option that, when false, hints to the user agent that a button for returning to the original tab does not make sense for the website's document picture-in-picture experience.

Fixes #113

@domenic
Copy link

domenic commented Feb 28, 2024

We generally don't codify specific user interface choices like "tabs" (vs. windows or others) in web APIs. Could Owner or Opener or something like that work instead?

@steimelchrome
Copy link
Collaborator Author

We generally don't codify specific user interface choices like "tabs" (vs. windows or others) in web APIs. Could Owner or Opener or something like that work instead?

Good call. I've changed the parameter name to allowReturnToOpener

@steimelchrome steimelchrome merged commit efcdf48 into main Mar 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to Remove "Back to Tab" Button in Picture-in-Picture (PiP) Window
2 participants