Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General specification maintenance #55

Merged
merged 5 commits into from
Sep 10, 2024
Merged

General specification maintenance #55

merged 5 commits into from
Sep 10, 2024

Conversation

reillyeon
Copy link
Collaborator

@reillyeon reillyeon commented Sep 10, 2024

This PR adds proper queuing to for tasks started while in-parallel, including a missing case from inside the requestPermission() steps.

A number of additional Bikeshed warnings are also resolved, including fixing references to Web Platform Tests and the renamed "Geolocation" specification. To add references to all existing Web Platform Tests, "fully active" checks needed to be added to the start() and requestPermission() methods. These checks are already implemented.

Fixed #54.


Preview | Diff

@reillyeon
Copy link
Collaborator Author

@jyasskin, please take a look.

index.bs Show resolved Hide resolved
Copy link
Member

@jyasskin jyasskin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@reillyeon reillyeon merged commit 6c7be3c into main Sep 10, 2024
2 checks passed
@reillyeon reillyeon deleted the maintainance branch September 10, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing tasks in parallel steps in Idle Detection API
2 participants