[explainer] Add interestGroups() method to shared storage worklet #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An interestGroups() method is added to the shared storage worklet, to return the Protected Audience interest groups associated with the shared storage origin's owner, with some additional metadata. This API provides the Protected Audience buyer with a better picture of what’s happening with their users, allowing for Private Aggregation reports (WICG/turtledove#1190).
dmdabbs
reviewed
Sep 5, 2024
| @@ -191,6 +191,20 @@ The shared storage worklet invocation methods (`addModule`, `run`, and `selectUR | |||
| * `sharedStorage.context` | |||
| * From inside a worklet created inside a [fenced frame](https://github.com/wicg/fenced-frame/), returns a string of contextual information, if any, that the embedder had written to the [fenced frame](https://github.com/wicg/fenced-frame/)'s [FencedFrameConfig](https://github.com/WICG/fenced-frame/blob/master/explainer/fenced_frame_config.md) before the [fenced frame](https://github.com/wicg/fenced-frame/)'s navigation. | |||
| * If no contextual information string had been written for the given frame, returns undefined. | |||
| * `interestGroups()` | |||
There was a problem hiding this comment.
This function is on the sharedStorage object or in the global context?
There was a problem hiding this comment.
It's in the global context of the shared storage worklet
dmdabbs
reviewed
Sep 5, 2024
| @@ -191,6 +191,20 @@ The shared storage worklet invocation methods (`addModule`, `run`, and `selectUR | |||
| * `sharedStorage.context` | |||
| * From inside a worklet created inside a [fenced frame](https://github.com/wicg/fenced-frame/), returns a string of contextual information, if any, that the embedder had written to the [fenced frame](https://github.com/wicg/fenced-frame/)'s [FencedFrameConfig](https://github.com/WICG/fenced-frame/blob/master/explainer/fenced_frame_config.md) before the [fenced frame](https://github.com/wicg/fenced-frame/)'s navigation. | |||
| * If no contextual information string had been written for the given frame, returns undefined. | |||
| * `interestGroups()` | |||
| * Returns a promise that resolves into an array of `StorageInterestGroup`. A `StorageInterestGroup` is a dictionary that extends the [AuctionAdInterestGroup](https://wicg.github.io/turtledove/#dictdef-auctionadinterestgroup) dictionary with the following attributes: | |||
| * unsigned long long `joinCount` | |||
There was a problem hiding this comment.
Are the values here subject to the noising and bucketing scheme?
There was a problem hiding this comment.
No, those won't be subject to the noising and bucketing scheme.
|
@jkarlin PTAL. Thanks! |
jkarlin
approved these changes
Sep 18, 2024
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Sep 19, 2024
Why: This prepares for the upcoming change to expose interest groups (and some metadata) to shared storage worklet. Explainer: WICG/shared-storage#180 Bug: 367992703 Change-Id: I81a8218d4a3a22d6cccbd2beab4dc29531a99694 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5872092 Reviewed-by: Russ Hamilton <[email protected]> Commit-Queue: Yao Xiao <[email protected]> Cr-Commit-Position: refs/heads/main@{#1357605}
xyaoinum
added a commit
to xyaoinum/turtledove
that referenced
this pull request
Oct 10, 2024
…s for owner" algorithm This is the Protected Audience side's spec update to support interestGroups() within shared storage worklet (WICG/shared-storage#180).
xyaoinum
added a commit
that referenced
this pull request
Oct 10, 2024
This is the Shared Storage side's spec update to support interestGroups() within shared storage worklet (#180). Sibling spec update PR for Protected Audience: WICG/turtledove#1299.
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Oct 16, 2024
Add interestGroups() to the shared storage worklet, to return the Protected Audience interest groups associated with the shared storage origin's owner, with some additional metadata. Implement this behind a runtime feature, which is implicitly controlled by a Finch flag. Explainer PR: WICG/shared-storage#180 Spec PR(s): 1) WICG/turtledove#1299 2) WICG/shared-storage#203 Bug: 367992703 Binary-Size: Size increase is unavoidable. Fuchsia-Binary-Size: Size increase is unavoidable. Change-Id: I5fc5767fa53a91f021d64a871a6dd9cb88f4431c
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Oct 16, 2024
Add interestGroups() to the shared storage worklet, to return the Protected Audience interest groups associated with the shared storage origin's owner, with some additional metadata. Implement this behind a runtime feature, which is implicitly controlled by a Finch flag. Explainer PR: WICG/shared-storage#180 Spec PR(s): 1) WICG/turtledove#1299 2) WICG/shared-storage#203 Bug: 367992703 Binary-Size: Size increase is unavoidable. Fuchsia-Binary-Size: Size increase is unavoidable. Change-Id: I5fc5767fa53a91f021d64a871a6dd9cb88f4431c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5696046 Reviewed-by: Daniel Cheng <[email protected]> Commit-Queue: Yao Xiao <[email protected]> Cr-Commit-Position: refs/heads/main@{#1369483}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Oct 16, 2024
Add interestGroups() to the shared storage worklet, to return the Protected Audience interest groups associated with the shared storage origin's owner, with some additional metadata. Implement this behind a runtime feature, which is implicitly controlled by a Finch flag. Explainer PR: WICG/shared-storage#180 Spec PR(s): 1) WICG/turtledove#1299 2) WICG/shared-storage#203 Bug: 367992703 Binary-Size: Size increase is unavoidable. Fuchsia-Binary-Size: Size increase is unavoidable. Change-Id: I5fc5767fa53a91f021d64a871a6dd9cb88f4431c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5696046 Reviewed-by: Daniel Cheng <[email protected]> Commit-Queue: Yao Xiao <[email protected]> Cr-Commit-Position: refs/heads/main@{#1369483}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Oct 16, 2024
Add interestGroups() to the shared storage worklet, to return the Protected Audience interest groups associated with the shared storage origin's owner, with some additional metadata. Implement this behind a runtime feature, which is implicitly controlled by a Finch flag. Explainer PR: WICG/shared-storage#180 Spec PR(s): 1) WICG/turtledove#1299 2) WICG/shared-storage#203 Bug: 367992703 Binary-Size: Size increase is unavoidable. Fuchsia-Binary-Size: Size increase is unavoidable. Change-Id: I5fc5767fa53a91f021d64a871a6dd9cb88f4431c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5696046 Reviewed-by: Daniel Cheng <[email protected]> Commit-Queue: Yao Xiao <[email protected]> Cr-Commit-Position: refs/heads/main@{#1369483}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Oct 18, 2024
…(), a=testonly Automatic update from web-platform-tests [shared storage] Implement interestGroup() Add interestGroups() to the shared storage worklet, to return the Protected Audience interest groups associated with the shared storage origin's owner, with some additional metadata. Implement this behind a runtime feature, which is implicitly controlled by a Finch flag. Explainer PR: WICG/shared-storage#180 Spec PR(s): 1) WICG/turtledove#1299 2) WICG/shared-storage#203 Bug: 367992703 Binary-Size: Size increase is unavoidable. Fuchsia-Binary-Size: Size increase is unavoidable. Change-Id: I5fc5767fa53a91f021d64a871a6dd9cb88f4431c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5696046 Reviewed-by: Daniel Cheng <[email protected]> Commit-Queue: Yao Xiao <[email protected]> Cr-Commit-Position: refs/heads/main@{#1369483} -- wpt-commits: eb87bbbacf996ab46607538a72ea0adaee229e7a wpt-pr: 48650
ErichDonGubler
pushed a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Oct 21, 2024
…(), a=testonly Automatic update from web-platform-tests [shared storage] Implement interestGroup() Add interestGroups() to the shared storage worklet, to return the Protected Audience interest groups associated with the shared storage origin's owner, with some additional metadata. Implement this behind a runtime feature, which is implicitly controlled by a Finch flag. Explainer PR: WICG/shared-storage#180 Spec PR(s): 1) WICG/turtledove#1299 2) WICG/shared-storage#203 Bug: 367992703 Binary-Size: Size increase is unavoidable. Fuchsia-Binary-Size: Size increase is unavoidable. Change-Id: I5fc5767fa53a91f021d64a871a6dd9cb88f4431c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5696046 Reviewed-by: Daniel Cheng <[email protected]> Commit-Queue: Yao Xiao <[email protected]> Cr-Commit-Position: refs/heads/main@{#1369483} -- wpt-commits: eb87bbbacf996ab46607538a72ea0adaee229e7a wpt-pr: 48650
i3roly
pushed a commit
to i3roly/firefox-dynasty
that referenced
this pull request
Oct 22, 2024
…(), a=testonly Automatic update from web-platform-tests [shared storage] Implement interestGroup() Add interestGroups() to the shared storage worklet, to return the Protected Audience interest groups associated with the shared storage origin's owner, with some additional metadata. Implement this behind a runtime feature, which is implicitly controlled by a Finch flag. Explainer PR: WICG/shared-storage#180 Spec PR(s): 1) WICG/turtledove#1299 2) WICG/shared-storage#203 Bug: 367992703 Binary-Size: Size increase is unavoidable. Fuchsia-Binary-Size: Size increase is unavoidable. Change-Id: I5fc5767fa53a91f021d64a871a6dd9cb88f4431c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5696046 Reviewed-by: Daniel Cheng <[email protected]> Commit-Queue: Yao Xiao <[email protected]> Cr-Commit-Position: refs/heads/main@{#1369483} -- wpt-commits: eb87bbbacf996ab46607538a72ea0adaee229e7a wpt-pr: 48650
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 22, 2024
…(), a=testonly Automatic update from web-platform-tests [shared storage] Implement interestGroup() Add interestGroups() to the shared storage worklet, to return the Protected Audience interest groups associated with the shared storage origin's owner, with some additional metadata. Implement this behind a runtime feature, which is implicitly controlled by a Finch flag. Explainer PR: WICG/shared-storage#180 Spec PR(s): 1) WICG/turtledove#1299 2) WICG/shared-storage#203 Bug: 367992703 Binary-Size: Size increase is unavoidable. Fuchsia-Binary-Size: Size increase is unavoidable. Change-Id: I5fc5767fa53a91f021d64a871a6dd9cb88f4431c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5696046 Reviewed-by: Daniel Cheng <dchengchromium.org> Commit-Queue: Yao Xiao <yaoxiachromium.org> Cr-Commit-Position: refs/heads/main{#1369483} -- wpt-commits: eb87bbbacf996ab46607538a72ea0adaee229e7a wpt-pr: 48650 UltraBlame original commit: 94a35dfacf6d42d04039e6c44dc8f2c1c3ff56c3
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 22, 2024
…(), a=testonly Automatic update from web-platform-tests [shared storage] Implement interestGroup() Add interestGroups() to the shared storage worklet, to return the Protected Audience interest groups associated with the shared storage origin's owner, with some additional metadata. Implement this behind a runtime feature, which is implicitly controlled by a Finch flag. Explainer PR: WICG/shared-storage#180 Spec PR(s): 1) WICG/turtledove#1299 2) WICG/shared-storage#203 Bug: 367992703 Binary-Size: Size increase is unavoidable. Fuchsia-Binary-Size: Size increase is unavoidable. Change-Id: I5fc5767fa53a91f021d64a871a6dd9cb88f4431c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5696046 Reviewed-by: Daniel Cheng <dchengchromium.org> Commit-Queue: Yao Xiao <yaoxiachromium.org> Cr-Commit-Position: refs/heads/main{#1369483} -- wpt-commits: eb87bbbacf996ab46607538a72ea0adaee229e7a wpt-pr: 48650 UltraBlame original commit: 94a35dfacf6d42d04039e6c44dc8f2c1c3ff56c3
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 22, 2024
…(), a=testonly Automatic update from web-platform-tests [shared storage] Implement interestGroup() Add interestGroups() to the shared storage worklet, to return the Protected Audience interest groups associated with the shared storage origin's owner, with some additional metadata. Implement this behind a runtime feature, which is implicitly controlled by a Finch flag. Explainer PR: WICG/shared-storage#180 Spec PR(s): 1) WICG/turtledove#1299 2) WICG/shared-storage#203 Bug: 367992703 Binary-Size: Size increase is unavoidable. Fuchsia-Binary-Size: Size increase is unavoidable. Change-Id: I5fc5767fa53a91f021d64a871a6dd9cb88f4431c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5696046 Reviewed-by: Daniel Cheng <dchengchromium.org> Commit-Queue: Yao Xiao <yaoxiachromium.org> Cr-Commit-Position: refs/heads/main{#1369483} -- wpt-commits: eb87bbbacf996ab46607538a72ea0adaee229e7a wpt-pr: 48650 UltraBlame original commit: 94a35dfacf6d42d04039e6c44dc8f2c1c3ff56c3
JensenPaul
pushed a commit
to WICG/turtledove
that referenced
this pull request
Oct 31, 2024
#1299) * [spec] Introduce StorageInterestGroup and "get storage interest groups for owner" algorithm This is the Protected Audience side's spec update to support interestGroups() within shared storage worklet (WICG/shared-storage#180). * return serialized owner * [spec] add failure handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An interestGroups() method is added to the shared storage worklet, to return the Protected Audience interest groups associated with the shared storage origin's owner, with some additional metadata.
This API provides the Protected Audience buyer with a better picture of what’s happening with their users, allowing for Private Aggregation reports (WICG/turtledove#1190).