-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Explainer] Support custom dataOrigin
in createWorklet
#198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have developers currently testing the Shared Storage API who have indicated they want to be able to run their worklet on a different origin from the origin that wrote the data. In particular, one of these two actions may be served by, e.g., a CDN, and the other by another domain. Third-party cookies allow sharing data at the site level. The current architecture of shared storage, however, only allows the invoking context's origin for `addModule()`/`createWorklet()` to be used as the shared storage data partition origin, or in the case of `createWorklet()`, the worklet script's origin may be manually selected as the data partition origin using the option `dataOrigin: "script-origin"`. We suggest making it possible for a worklet script to use shared storage data from an arbitrary origin other than the worklet script's origin or the invoking context's origin on an opt-in basis. The data-owning origin would have to opt-in for data use to occur, as data processing could modify the data origin's, send reports, and would affect its shared storage privacy budget. While the worklet script will be able to process the data-owning origin's data within a shared storage worklet, the current restrictions will remain in place on output of shared storage data.
xyaoinum
reviewed
Sep 23, 2024
xyaoinum
reviewed
Oct 29, 2024
pythagoraskitty
added a commit
to pythagoraskitty/wpt
that referenced
this pull request
Nov 12, 2024
We add a route for /.well-known/shared-storage/trusted-origins to RoutesBuilder in order to test custom data origins for shared storage. See the explainer update: WICG/shared-storage#198.
pythagoraskitty
added a commit
to pythagoraskitty/wpt
that referenced
this pull request
Nov 12, 2024
We add a route for /.well-known/shared-storage/trusted-origins to RoutesBuilder in order to test custom data origins for shared storage. See the explainer update: WICG/shared-storage#198. (This is a second attempt, after closing the failed web-platform-tests#49112.)
DanielRyanSmith
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Nov 12, 2024
We add a route for /.well-known/shared-storage/trusted-origins to RoutesBuilder in order to test custom data origins for shared storage. See the explainer update: WICG/shared-storage#198. (This is a second attempt, after closing the failed #49112.)
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Nov 15, 2024
… to RoutesBuilder (attempt 2), a=testonly Automatic update from web-platform-tests Add Shared Storage trusted origins route to RoutesBuilder (#49126) We add a route for /.well-known/shared-storage/trusted-origins to RoutesBuilder in order to test custom data origins for shared storage. See the explainer update: WICG/shared-storage#198. (This is a second attempt, after closing the failed web-platform-tests/wpt#49112.) -- wpt-commits: b6027abc9fb7e6d12b0d7451458035a5fb6335a9 wpt-pr: 49126
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Nov 16, 2024
… to RoutesBuilder (attempt 2), a=testonly Automatic update from web-platform-tests Add Shared Storage trusted origins route to RoutesBuilder (#49126) We add a route for /.well-known/shared-storage/trusted-origins to RoutesBuilder in order to test custom data origins for shared storage. See the explainer update: WICG/shared-storage#198. (This is a second attempt, after closing the failed web-platform-tests/wpt#49112.) -- wpt-commits: b6027abc9fb7e6d12b0d7451458035a5fb6335a9 wpt-pr: 49126 UltraBlame original commit: 11aa780661dcbc85c129d75f66e9ef1ffc6394b7
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Nov 16, 2024
… to RoutesBuilder (attempt 2), a=testonly Automatic update from web-platform-tests Add Shared Storage trusted origins route to RoutesBuilder (#49126) We add a route for /.well-known/shared-storage/trusted-origins to RoutesBuilder in order to test custom data origins for shared storage. See the explainer update: WICG/shared-storage#198. (This is a second attempt, after closing the failed web-platform-tests/wpt#49112.) -- wpt-commits: b6027abc9fb7e6d12b0d7451458035a5fb6335a9 wpt-pr: 49126 UltraBlame original commit: 11aa780661dcbc85c129d75f66e9ef1ffc6394b7
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Nov 16, 2024
… to RoutesBuilder (attempt 2), a=testonly Automatic update from web-platform-tests Add Shared Storage trusted origins route to RoutesBuilder (#49126) We add a route for /.well-known/shared-storage/trusted-origins to RoutesBuilder in order to test custom data origins for shared storage. See the explainer update: WICG/shared-storage#198. (This is a second attempt, after closing the failed web-platform-tests/wpt#49112.) -- wpt-commits: b6027abc9fb7e6d12b0d7451458035a5fb6335a9 wpt-pr: 49126 UltraBlame original commit: 11aa780661dcbc85c129d75f66e9ef1ffc6394b7
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Nov 18, 2024
… to RoutesBuilder (attempt 2), a=testonly Automatic update from web-platform-tests Add Shared Storage trusted origins route to RoutesBuilder (#49126) We add a route for /.well-known/shared-storage/trusted-origins to RoutesBuilder in order to test custom data origins for shared storage. See the explainer update: WICG/shared-storage#198. (This is a second attempt, after closing the failed web-platform-tests/wpt#49112.) -- wpt-commits: b6027abc9fb7e6d12b0d7451458035a5fb6335a9 wpt-pr: 49126
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have developers currently testing the Shared Storage API who have indicated they want to be able to run their worklet on a different origin from the origin that wrote the data. In particular, one of these two actions may be served by, e.g., a CDN, and the other by another domain.
Third-party cookies allow sharing data at the site level. The current architecture of shared storage, however, only allows the invoking context's origin for
addModule()
/createWorklet()
to be used as the shared storage data partition origin, or in the case ofcreateWorklet()
, the worklet script's origin may be manually selected as the data partition origin using the optiondataOrigin: "script-origin"
.We suggest making it possible for a worklet script to use shared storage data from an arbitrary origin other than the worklet script's origin or the invoking context's origin. The data origin would have to opt-in for data use to occur, as data processing could modify the data origin's data, send reports, and would affect its shared storage privacy budget.
While the worklet script will be able to process the data origin's data within a shared storage worklet, the current restrictions will remain in place on output of shared storage data.