-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce "delegatesFocus" flag to shadow root #126
Comments
Why can't we always use |
I don't see how that solves the problem of skipping the host element adequately. |
I'm saying that skip the host element if its shadow DOM contains an element with |
But if it only contains a single |
Let me summarize the status of this issue to get the ball rolling again.
|
Yes, I would like to see how shadow DOM affects the focus model we have today (and even that likely has holes still). After that is explained it would be easier to reason about any changes to it. |
@TakayoshiKochi , could you summarize the status of this issue? This is a blocking issue for v1. |
Never mind about my proposal. I was misunderstanding the problem at the time. Now that I understand the problem better, I think it's fine to have a flag. If we're going to have |
Also, do we really need |
The For example |
Thus, the changes I would like to introduce is basically listed here,
@rniwa @travisleithead @annevk any opinion for each item above? |
I think 5 should also be recursive, no? Will we do something similar for slots? |
Re <div#host1>
<:shadow>
<div#host2>
<:shadow>
<input#inner>
</:shadow>
<input#outer>
</:shadow>
</div> Because a slot is not focusable, I don't think identical mechanism is necessary, but regarding to |
Let's not block this issue on the issue #358 or the issue #308. I think the proposal in #126 (comment) is sound. |
I start working on updating the specs. |
To fix focusability and focus navigation order issue (W3C 25473, Chromium 380445), introduce
delegatesFocus
flag under shadow root, to address some shortcomings thatthe default focus navigation behavior (defined in the Shadow DOM spec) has.
Detailed doc is here:
https://github.com/TakayoshiKochi/tabindex-focus-navigation-explainer/blob/master/TabindexFocusNavigationExplainer.md
I'll post the proposal doc soon.
This is experimentally implmented in Blink Chromium 496005
The text was updated successfully, but these errors were encountered: