The /checkout endpoint should ignore CSRF #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If this endpoint is not added to the ignore CSRF list then first time users will get an error when attempting checkout which is not preferrable. Additionally there is no harm in not having the endpoint CSRF protected as there is no possible harm.
JoepdeJong
approved these changes
May 27, 2024
dsluijk
deleted the
492-issues-with-first-time-checkout-as-unauthenticatedanonymous-user
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this endpoint should not be under CSRF protection. If it is, then first time users or people who have not used the application in a while will get an error page when trying to checkout the first time, which is not intended.
The issue and reasoning for adding this to the ignore filter has been discussed in issue #492 .
fixes #492