Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template tags possibly causing compatibility issues with other plugins #600

Closed
8 of 19 tasks
ice9js opened this issue Sep 19, 2021 · 0 comments
Closed
8 of 19 tasks
Labels

Comments

@ice9js
Copy link

ice9js commented Sep 19, 2021

Describe the bug

Note: looking at master this might not be an issue anymore but I figured it's worth noting anyway. Feel free to close if that's the case.

It seems template tags are a bit of a grey area in WordPress and other plugins could be using similar tags or remove them entirely. Hence it might not be the most reliable way to inject buttons/navigation into the lightbox.

As described in the issue on Nimble Builder Plugin, when the two are installed along each other Modula's navigation doesn't display at all.

To Reproduce

  1. Make sure to have both Nimble Page Builder and Modula installed along each other.
  2. Proceed to create a gallery with arrow navigation enabled.
  3. When viewing the page and clicking on an image, the lightbox will appear but without any arrows or a close button making the page effectively stuck.

Expected behavior

The gallery should render as expected.

Proposed solution
Like I said, might not be a problem anymore although I also don't necessarily see a reason to use template tags over something like the class name to inject the appropriate UI, where the latter would seem to have been more reliable in this case.

Hope this helps!

  • Which addons do you have installed:
  • Modula PRO
  • Albums
  • Slider
  • Lightbox Slideshow
  • Password Protect
  • Watermark
  • Deeplink
  • Right-Click Protection
  • Advanced Shortcode
  • SpeedUp
  • Video
  • Which browser is affected (or browsers):
  • Chrome
  • Firefox
  • Safari
  • Other
  • Which device is affected (or devices):
  • Desktop
  • Tablet
  • Mobile
  • Other

Used versions

  • WordPress version: 5.8.1
  • Modula Lite version: 2.5.4
  • Modula PRO version: -
  • Albums version: -
  • Slider version: -
  • Lightbox Slideshow version: -
  • Password Protect version: -
  • Watermark version: -
  • Deeplink version: -
  • Right-Click Protection version: -
  • Advanced Shortcode version: -
  • SpeedUp version: -
  • Video version: -
@ice9js ice9js added the bug label Sep 19, 2021
@giucu91 giucu91 closed this as completed Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants