Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggressive removal of other plugins' template tags #878

Open
ice9js opened this issue Sep 19, 2021 · 0 comments
Open

Aggressive removal of other plugins' template tags #878

ice9js opened this issue Sep 19, 2021 · 0 comments

Comments

@ice9js
Copy link

ice9js commented Sep 19, 2021

Hello there!

I noticed that this plugin is quite aggressive in how it removes template tags from HTML content - in addition of processing its own tags it's also stripping any others that might be used by different plugins causing them not to work.
For example, in case of the Modula gallery plugin it'll cause the navigation not to render effectively making the view stuck.

With the tags not following any namespaces, it's a bit of a grey area although I'd say it should be fine to just leave those that aren't part of nimble builder as they are.

Steps to reproduce

  • Install the Modula gallery plugin which uses {{arrows}} and {{buttons}} tags and create a gallery with 'arrow navigation' enabled.
  • When viewing the page, you should notice empty .modula-fancybox-toolbar and .modula-fancybox-navigation elements. That's where the tags would go and their absence causes the plugins' JS not to inject the content.

Possible solution

Change ccat-constants-and-helper-functions.php#L2112 from:

return null;

to

return matches[0];
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant