-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Themes 2012] Inline Editing | Small Promo Block #2202
base: arc-themes-release-version-2.5.2
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's either an unnecessary flag here or missing logic.
const shouldLazyLoad = lazyLoad && !isAdmin; | ||
const editable = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
editable will always be true, so it's not needed...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nschubach Removed editable
Description
Jira Ticket: THEMES-2012
inline edit certain content elements on a small promo block within PageBuilder Editor, so that I can curate the homepage small promo to drive engagement.
Test Steps
git checkout THEMES-2012
npx fusion start -f -l @wpmwdia/small-promo-block
Before:
After: