Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

THEMES-1332: Replace invalid characters in content #656

Merged
merged 2 commits into from
Jan 19, 2024
Merged

Conversation

vgalatro
Copy link
Contributor

This PR fixes the options of the create method, so that invalid characters are removed from the XML content.

Test Instructions

  1. Checkout the branch git checkout THEMES-1332
  2. Run the unit tests and ensure the ones for XmlOutput are passing.

Copy link

changeset-bot bot commented Jan 18, 2024

🦋 Changeset detected

Latest commit: 3285622

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@wpmedia/feeds-xml-output Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vgalatro vgalatro marked this pull request as ready for review January 19, 2024 15:05
Copy link
Contributor

@rmbrntt rmbrntt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work @vgalatro

@vgalatro vgalatro merged commit 435fd26 into develop Jan 19, 2024
3 checks passed
@github-actions github-actions bot mentioned this pull request Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants