Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core download issue when Github release file is in draft (latest-master) #832

Open
Rolzad73 opened this issue Aug 4, 2016 · 8 comments
Open

Comments

@Rolzad73
Copy link
Member

Rolzad73 commented Aug 4, 2016

I have noticed that when the latest-master release files on github have been updated (I think Travis script handles this?) the link to core looks similar to this:

https://github.com/WagicProject/wagic/releases/download/untagged-4d18d2f30312a41b2e82/Wagic-core.zip

For new installs of WTH, the core file is attempting to download from this link:

https://github.com/WagicProject/wagic/releases/download/latest-master/Wagic-core.zip

At first I thought that the bug may just be a co-incidence of somone manually updating the release and it would not occur often. But when I see that Travis will be updating on every master commit/merge, this seems to be a re-occuring problem.

While it may only happen when first installing (so, low chance of happening), it may be investigated as a network or storage bug mistakenly.

@xawotihs
Copy link
Member

xawotihs commented Aug 5, 2016

Hum, the second link is only available when the release is in the state "pre-release". Sometimes, the release stays in the state "draft", in this case the link is broken. I don't really understand why the release stays in the state "draft" ... my guess is that it's somewhere a bug between Travis and Github, our script set the flag correctly I think.

@kevlahnota
Copy link
Contributor

Also the Windows-build is missing for a while (I think its not uploaded anymore)

@Rolzad73
Copy link
Member Author

Also the Windows-build is missing for a while (I think its not uploaded anymore)

I have a comment about that I saw today when testing build config.
The Windows one IS getting uploaded from AppVeyor (it finishes first). I downloaded it and tested it for a while (Linux, ran in Wine i think) Ran well.

But I think something is happening after the Travis build uploads, overridding the tag possibly?? and the new "latest-master" tag has the new artifacts?

Not sure of a fix if that is what it is. Issue incoming.

@Rolzad73
Copy link
Member Author

I think we got the builds uploading figured out.

Also, retested this issue. I understand how there can be a small chance of this intermediate state where a download fails. So small a chance, closing.

@Rolzad73 Rolzad73 reopened this Feb 2, 2017
@Rolzad73
Copy link
Member Author

Rolzad73 commented Feb 2, 2017

I guess its not a small chance....

Travis log shows that the core.zip uploaded, but no file can be seen on random builds

@Rolzad73 Rolzad73 closed this as completed Feb 2, 2017
@Rolzad73 Rolzad73 reopened this Feb 2, 2017
@SlippingBack
Copy link

I'm having difficulties downloading the latest core from the Android apk. Is there a direct link available to download it?

@kevlahnota
Copy link
Contributor

@SlippingBack
Copy link

SlippingBack commented Apr 12, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants