[Verify] Add 'isScam' field #1116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-lsvk
temporarily deployed
to
internal
GitHub Actions
Inactive
alexander-lsvk
temporarily deployed
to
internal
GitHub Actions
Inactive
alexander-lsvk
temporarily deployed
to
internal
GitHub Actions
Inactive
alexander-lsvk
temporarily deployed
to
internal
GitHub Actions
Inactive
radeknovis
approved these changes
Sep 19, 2023
| "revision": "04bee4ad86d74d4cb4d7101ff826d6e355301ba9", | ||
| "version": "8.9.4" | ||
| "revision": "12998398eb51e2e8ff7098163fa97d305eee6d87", | ||
| "version": "8.11.0" |
There was a problem hiding this comment.
We should probably pin the version of this dependency so we avoid those
|
|
||
| Text("Cannot verify") | ||
| .foregroundColor(.orange) | ||
| .font(.system(size: 14, weight: .semibold, design: .rounded)) |
There was a problem hiding this comment.
You can apply these modifiers only once to the entire HStack, removing the duplication.
| .padding(5) | ||
| .background(Color.red.opacity(0.15)) | ||
| .cornerRadius(10) | ||
| .padding(.top, 8) |
There was a problem hiding this comment.
nit: Same with these padding and cornerRadius modifiers. You can wrap the entire switch in a Group and apply them there e.g. Again just to avoid some duplication
Group {
switch foo {
case .bar:
HStack { ... }
}
}
.padding(5)
.cornerRadius(10)
.padding(.top, 8)| .frame(maxWidth: .infinity) | ||
| .padding() | ||
| .background(Color.red.opacity(0.15)) | ||
| .cornerRadius(20) |
There was a problem hiding this comment.
nit: same thing with modifiers here
alexander-lsvk
temporarily deployed
to
internal
GitHub Actions
Inactive
alexander-lsvk
temporarily deployed
to
internal
GitHub Actions
Inactive
llbartekll
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due Dilligence