Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: verifyContext in pending request store #3632

Merged
merged 2 commits into from
Sep 12, 2023

Conversation

ganchoradkov
Copy link
Member

Description

Storing verifyContext along pending requests to reduce overhead & redundant duplicate GET calls

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Draft PR (breaking/non-breaking change which needs more work for having a proper functionality [Mark this PR as ready to review only when completely ready])
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How has this been tested?

dogfooding

Checklist

  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Additional Information (Optional)

Please include any additional information that may be useful for the reviewer.

@ganchoradkov ganchoradkov merged commit 7a8ba84 into v2.0 Sep 12, 2023
13 checks passed
@ganchoradkov ganchoradkov deleted the feat/store-verify-context branch September 12, 2023 13:49
@ganchoradkov ganchoradkov mentioned this pull request Sep 12, 2023
20 tasks
renovate bot referenced this pull request in valora-inc/wallet Sep 18, 2023
….10.1 (#4201)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[@walletconnect/react-native-compat](https://togithub.com/walletconnect/walletconnect-monorepo)
| [`^2.10.0` ->
`^2.10.1`](https://renovatebot.com/diffs/npm/@walletconnect%2freact-native-compat/2.10.0/2.10.1)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@walletconnect%2freact-native-compat/2.10.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@walletconnect%2freact-native-compat/2.10.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@walletconnect%2freact-native-compat/2.10.0/2.10.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@walletconnect%2freact-native-compat/2.10.0/2.10.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>walletconnect/walletconnect-monorepo
(@&#8203;walletconnect/react-native-compat)</summary>

###
[`v2.10.1`](https://togithub.com/WalletConnect/walletconnect-monorepo/releases/tag/2.10.1)

[Compare
Source](https://togithub.com/walletconnect/walletconnect-monorepo/compare/2.10.0...2.10.1)

#### What's Changed

- chore: prep for `2.10.0` release by
[@&#8203;ganchoradkov](https://togithub.com/ganchoradkov) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/3471](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/3471)
- chore(deps): update actions/checkout action to v3 by
[@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/3505](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/3505)
- feat/expand core tests for issue
[#&#8203;2737](https://togithub.com/walletconnect/walletconnect-monorepo/issues/2737)
by [@&#8203;JonathanConn](https://togithub.com/JonathanConn) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/3087](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/3087)
- chore(deps): update aws-actions/configure-aws-credentials action to v3
by [@&#8203;renovate](https://togithub.com/renovate) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/3547](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/3547)
- chore: expose EthereumProviderOptions interface by
[@&#8203;Jurshsmith](https://togithub.com/Jurshsmith) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/3553](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/3553)
- refactor: disable retry on fatal errors by
[@&#8203;ganchoradkov](https://togithub.com/ganchoradkov) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/3558](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/3558)
- refactor: adds `eth_sendTransaction` & `personal_sign` to default opt…
by [@&#8203;ganchoradkov](https://togithub.com/ganchoradkov) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/3564](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/3564)
- feat: validate topic exists by
[@&#8203;HarryET](https://togithub.com/HarryET) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/3529](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/3529)
- fix: default rpc provider url by
[@&#8203;ganchoradkov](https://togithub.com/ganchoradkov) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/3569](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/3569)
- Feat/pairing idempotency by
[@&#8203;ganchoradkov](https://togithub.com/ganchoradkov) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/3574](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/3574)
- fix: `rejectZero` flag on key derivation by
[@&#8203;ganchoradkov](https://togithub.com/ganchoradkov) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/3579](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/3579)
- refactor: verify logs level by
[@&#8203;ganchoradkov](https://togithub.com/ganchoradkov) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/3626](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/3626)
- feat: added `isScam` to verify by
[@&#8203;ganchoradkov](https://togithub.com/ganchoradkov) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/3613](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/3613)
- feat: `verifyContext` in pending request store by
[@&#8203;ganchoradkov](https://togithub.com/ganchoradkov) in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/3632](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/3632)

#### New Contributors

- [@&#8203;Jurshsmith](https://togithub.com/Jurshsmith) made their first
contribution in
[https://github.com/WalletConnect/walletconnect-monorepo/pull/3553](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/3553)

**Full Changelog**:
WalletConnect/walletconnect-monorepo@2.10.0...2.10.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone
America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone
America/Los_Angeles.

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/valora-inc/wallet).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi44My4wIiwidXBkYXRlZEluVmVyIjoiMzYuODMuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants