-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: verifyContext
in pending request store
#3632
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glitch-txs
approved these changes
Sep 12, 2023
20 tasks
renovate bot
referenced
this pull request
in valora-inc/wallet
Sep 18, 2023
….10.1 (#4201) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@walletconnect/react-native-compat](https://togithub.com/walletconnect/walletconnect-monorepo) | [`^2.10.0` -> `^2.10.1`](https://renovatebot.com/diffs/npm/@walletconnect%2freact-native-compat/2.10.0/2.10.1) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@walletconnect%2freact-native-compat/2.10.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@walletconnect%2freact-native-compat/2.10.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@walletconnect%2freact-native-compat/2.10.0/2.10.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@walletconnect%2freact-native-compat/2.10.0/2.10.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>walletconnect/walletconnect-monorepo (@​walletconnect/react-native-compat)</summary> ### [`v2.10.1`](https://togithub.com/WalletConnect/walletconnect-monorepo/releases/tag/2.10.1) [Compare Source](https://togithub.com/walletconnect/walletconnect-monorepo/compare/2.10.0...2.10.1) #### What's Changed - chore: prep for `2.10.0` release by [@​ganchoradkov](https://togithub.com/ganchoradkov) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/3471](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/3471) - chore(deps): update actions/checkout action to v3 by [@​renovate](https://togithub.com/renovate) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/3505](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/3505) - feat/expand core tests for issue [#​2737](https://togithub.com/walletconnect/walletconnect-monorepo/issues/2737) by [@​JonathanConn](https://togithub.com/JonathanConn) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/3087](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/3087) - chore(deps): update aws-actions/configure-aws-credentials action to v3 by [@​renovate](https://togithub.com/renovate) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/3547](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/3547) - chore: expose EthereumProviderOptions interface by [@​Jurshsmith](https://togithub.com/Jurshsmith) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/3553](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/3553) - refactor: disable retry on fatal errors by [@​ganchoradkov](https://togithub.com/ganchoradkov) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/3558](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/3558) - refactor: adds `eth_sendTransaction` & `personal_sign` to default opt… by [@​ganchoradkov](https://togithub.com/ganchoradkov) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/3564](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/3564) - feat: validate topic exists by [@​HarryET](https://togithub.com/HarryET) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/3529](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/3529) - fix: default rpc provider url by [@​ganchoradkov](https://togithub.com/ganchoradkov) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/3569](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/3569) - Feat/pairing idempotency by [@​ganchoradkov](https://togithub.com/ganchoradkov) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/3574](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/3574) - fix: `rejectZero` flag on key derivation by [@​ganchoradkov](https://togithub.com/ganchoradkov) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/3579](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/3579) - refactor: verify logs level by [@​ganchoradkov](https://togithub.com/ganchoradkov) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/3626](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/3626) - feat: added `isScam` to verify by [@​ganchoradkov](https://togithub.com/ganchoradkov) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/3613](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/3613) - feat: `verifyContext` in pending request store by [@​ganchoradkov](https://togithub.com/ganchoradkov) in [https://github.com/WalletConnect/walletconnect-monorepo/pull/3632](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/3632) #### New Contributors - [@​Jurshsmith](https://togithub.com/Jurshsmith) made their first contribution in [https://github.com/WalletConnect/walletconnect-monorepo/pull/3553](https://togithub.com/WalletConnect/walletconnect-monorepo/pull/3553) **Full Changelog**: WalletConnect/walletconnect-monorepo@2.10.0...2.10.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 5pm,every weekend" in timezone America/Los_Angeles, Automerge - "after 5pm,every weekend" in timezone America/Los_Angeles. 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/valora-inc/wallet). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi44My4wIiwidXBkYXRlZEluVmVyIjoiMzYuODMuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Storing
verifyContext
along pending requests to reduce overhead & redundant duplicate GET callsType of change
How has this been tested?
dogfooding
Checklist
Additional Information (Optional)
Please include any additional information that may be useful for the reviewer.