Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add no-extraneous-dependencies lint rule #5318

Merged
merged 3 commits into from
Oct 9, 2024
Merged

Conversation

ganchoradkov
Copy link
Member

Description

Adding no-extraneous-dependencies lint rule to be warned early and avoid cases of invalid builds #5288

Type of change

  • Chore (non-breaking change that addresses non-functional tasks, maintenance, or code quality improvements)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Draft PR (breaking/non-breaking change which needs more work for having a proper functionality [Mark this PR as ready to review only when completely ready])
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How has this been tested?

ci

Checklist

  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Additional Information (Optional)

Please include any additional information that may be useful for the reviewer.

@arein arein added the accepted label Aug 29, 2024
@WalletConnect WalletConnect deleted a comment from Vt2049 Sep 23, 2024
# Conflicts:
#	package-lock.json
#	packages/core/package.json
#	providers/ethereum-provider/package.json
#	providers/universal-provider/package.json
@ganchoradkov ganchoradkov merged commit c7914ad into v2.0 Oct 9, 2024
9 checks passed
@ganchoradkov ganchoradkov deleted the chore/lint-rules branch October 9, 2024 08:40
@ganchoradkov ganchoradkov mentioned this pull request Oct 9, 2024
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants